Compare commits

..

No commits in common. "a4e5f0252d20fb3d37821baf9b7661202f555d67" and "dd199a5afea01c3b06a40f07014fd561ad5798b1" have entirely different histories.

4 changed files with 10 additions and 76 deletions

View File

@ -23,8 +23,6 @@ docker run --rm -p 8080:8080 --name pos-transactions-bff agilewebs/pos-transacti
## Runtime Notes ## Runtime Notes
- Exposes REST edge endpoints for transaction summary and payment capture. - Exposes REST edge endpoints for transaction summary and payment capture.
- Requires `ThalosAuth__BaseAddress` to resolve Thalos session introspection endpoint.
- Returns standardized auth failures (`401|403|503`) with `x-correlation-id` propagation.
## Health Endpoint Consistency ## Health Endpoint Consistency

View File

@ -38,13 +38,8 @@ Standard auth error payload:
- `401`: missing or invalid session - `401`: missing or invalid session
- `403`: permission denied by identity service - `403`: permission denied by identity service
- `503`: identity service unavailable or timeout (`identity_unavailable|identity_timeout`)
## Correlation ## Correlation
- Incoming/outgoing correlation header: `x-correlation-id` - Incoming/outgoing correlation header: `x-correlation-id`
- Correlation ID is forwarded to Thalos session validation call. - Correlation ID is forwarded to Thalos session validation call.
## Validation Rule
- Successful session introspection must also include `isAuthenticated=true` in Thalos response payload.

View File

@ -3,7 +3,6 @@ using Microsoft.Extensions.Primitives;
using Pos.Transactions.Bff.Application.Adapters; using Pos.Transactions.Bff.Application.Adapters;
using Pos.Transactions.Bff.Application.Handlers; using Pos.Transactions.Bff.Application.Handlers;
using Pos.Transactions.Bff.Contracts.Requests; using Pos.Transactions.Bff.Contracts.Requests;
using Pos.Transactions.Bff.Rest.Security;
const string CorrelationHeaderName = "x-correlation-id"; const string CorrelationHeaderName = "x-correlation-id";
const string SessionAccessCookieName = "thalos_session"; const string SessionAccessCookieName = "thalos_session";
@ -110,30 +109,8 @@ async Task<IResult?> EnforceSessionAsync(
request.Headers.TryAddWithoutValidation("Cookie", cookieHeader); request.Headers.TryAddWithoutValidation("Cookie", cookieHeader);
} }
HttpResponseMessage response; using var response = await httpClientFactory.CreateClient("ThalosAuth").SendAsync(request, ct);
try
{
response = await httpClientFactory.CreateClient("ThalosAuth").SendAsync(request, ct);
}
catch (HttpRequestException)
{
return ErrorResponse(
StatusCodes.Status503ServiceUnavailable,
"identity_unavailable",
"Identity service is temporarily unavailable.",
correlationId);
}
catch (TaskCanceledException)
{
return ErrorResponse(
StatusCodes.Status503ServiceUnavailable,
"identity_timeout",
"Identity service did not respond in time.",
correlationId);
}
using (response)
{
if (response.StatusCode == HttpStatusCode.Forbidden) if (response.StatusCode == HttpStatusCode.Forbidden)
{ {
return ErrorResponse(StatusCodes.Status403Forbidden, "forbidden", "Permission denied.", correlationId); return ErrorResponse(StatusCodes.Status403Forbidden, "forbidden", "Permission denied.", correlationId);
@ -149,13 +126,6 @@ async Task<IResult?> EnforceSessionAsync(
return ErrorResponse(StatusCodes.Status401Unauthorized, "session_invalid", "Session validation failed.", correlationId); return ErrorResponse(StatusCodes.Status401Unauthorized, "session_invalid", "Session validation failed.", correlationId);
} }
var payload = await response.Content.ReadAsStringAsync(ct);
if (!SessionMePayloadParser.IsAuthenticated(payload))
{
return ErrorResponse(StatusCodes.Status401Unauthorized, "session_invalid", "Session validation failed.", correlationId);
}
}
return null; return null;
} }

View File

@ -1,29 +0,0 @@
using System.Text.Json;
namespace Pos.Transactions.Bff.Rest.Security;
public static class SessionMePayloadParser
{
public static bool IsAuthenticated(string payload)
{
if (string.IsNullOrWhiteSpace(payload))
{
return false;
}
try
{
using var document = JsonDocument.Parse(payload);
if (!document.RootElement.TryGetProperty("isAuthenticated", out var value))
{
return false;
}
return value.ValueKind == JsonValueKind.True;
}
catch (JsonException)
{
return false;
}
}
}